Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export options types and interfaces #872

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

trev-gulls
Copy link
Contributor

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Apr 9, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #872 (780c3e8) into main (4365f45) will not change coverage.
The diff coverage is n/a.

❗ Current head 780c3e8 differs from pull request most recent head e176ea3. Consider uploading reports for the commit e176ea3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   66.08%   66.08%           
=======================================
  Files          13       13           
  Lines        1200     1200           
  Branches      353      353           
=======================================
  Hits          793      793           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4365f45...e176ea3. Read the comment docs.

src/types/options/index.ts Outdated Show resolved Hide resolved
@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific and removed untriaged labels Apr 9, 2021
@seratch seratch added this to the 3.4.0 milestone Apr 9, 2021
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@trev-gulls trev-gulls requested a review from seratch April 9, 2021 23:07
@seratch
Copy link
Member

seratch commented Apr 9, 2021

Thanks @trevor-gullstad - this pull request already looks great to me 👍 After waiting for other maintainers' response, we can merge this PR shortly.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @trevor-gullstad!!

@stevengill stevengill merged commit 5dd1d56 into slackapi:main Apr 9, 2021
@trev-gulls
Copy link
Contributor Author

Thanks @seratch and @stevengill when can I expect to see these changes reflected in a new release?

@seratch
Copy link
Member

seratch commented Apr 12, 2021

@trevor-gullstad We are still working on a few other tasks for the next release: https://github.com/slackapi/bolt-js/issues?q=is%3Aissue+is%3Aopen+milestone%3A3.4.0
We haven't decided the date for the next release yet but it won't take long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants