-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async signingSecret on ExpressReceiver #877
Conversation
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 66.08% 66.11% +0.02%
==========================================
Files 13 13
Lines 1200 1201 +1
Branches 353 354 +1
==========================================
+ Hits 793 794 +1
Misses 338 338
Partials 69 69
Continue to review full report at Codecov.
|
Hey @gmathieu 👋🏻 I saw #875. Thanks for taking the time to create that pull request! While we didn't merge it, I'm glad to see we have a tight solution for developers while not adding more maintenance to our project. Definitely appreciate your understanding with it too! I think this pull request is a fair enhancement. I've added a few maintainers as reviewers, so that someone can take a deeper look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting this enhancement! Looks great to me 👍
Hmm... it looks like this pull request was ✅ approved but 🚫 closed before it was ⬇️ merged. 🙃 Since the branch was deleted, I'm not sure if we can restore the existing PR. @gmathieu would you mind pushing the branch back up? It may allow you to re-open this PR. Otherwise, we'll need to open another (just reference this PR for simplicity). |
@mwbrooks sorry about that. Not sure what happened |
@gmathieu No worries! I was a little confused too but it's great that GitHub was able to gracefully recover the pull request when you restored the branch. 🎉 Merged in your work. Thanks a bunch for the contribution! 🙇🏻 |
Summary
Add async support to the
signingSecret
for theExpressReceiver
. This is useful when using secret managers (ex. https://github.com/googleapis/nodejs-secret-manager).Requirements