Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #916

Merged
merged 1 commit into from
May 12, 2021
Merged

Fix typo #916

merged 1 commit into from
May 12, 2021

Conversation

p-chan
Copy link
Contributor

@p-chan p-chan commented May 12, 2021

Summary

Fix typo, コオ to こと

Requirements (place an x in each [ ])

s/コオ/こと/
@gitwave gitwave bot added the untriaged label May 12, 2021
@CLAassistant
Copy link

CLAassistant commented May 12, 2021

CLA assistant check
All committers have signed the CLA.

@mwbrooks mwbrooks requested a review from seratch May 12, 2021 18:24
@mwbrooks mwbrooks added docs M-T: Documentation work only and removed untriaged labels May 12, 2021
@mwbrooks mwbrooks requested a review from shaydewael May 12, 2021 18:25
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #916 (64c7ca8) into main (b0d733a) will not change coverage.
The diff coverage is n/a.

❗ Current head 64c7ca8 differs from pull request most recent head dccfa02. Consider uploading reports for the commit dccfa02 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          13       13           
  Lines        1205     1205           
  Branches      355      355           
=======================================
  Hits          798      798           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d733a...dccfa02. Read the comment docs.

@mwbrooks
Copy link
Member

Hi @p-chan 👋🏻 Thanks a lot for the documentation update and signing the CLA! I've added @seratch as a reviewer. He'll be able to review the changes and merge the update 🙂

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@seratch seratch merged commit c432b3a into slackapi:main May 12, 2021
@seratch seratch added this to the 3.4.0 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants