Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ReactionRemovedEvent type #918

Merged
merged 1 commit into from
May 14, 2021
Merged

Updated ReactionRemovedEvent type #918

merged 1 commit into from
May 14, 2021

Conversation

rr-codes
Copy link
Contributor

Summary

Closes #917

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label May 13, 2021
@mwbrooks mwbrooks added enhancement M-T: A feature request for new functionality semver:patch and removed untriaged labels May 13, 2021
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rr-codes, congrats on your first contribution and thanks for signing the CLA!

This PR looks good to me. I'd like @seratch to look over it briefly before we merge, since he's been doing a lot of TypeScript work recently.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #918 (0e439fd) into main (c432b3a) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e439fd differs from pull request most recent head 03079c5. Consider uploading reports for the commit 03079c5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          13       13           
  Lines        1205     1205           
  Branches      355      355           
=======================================
  Hits          798      798           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c432b3a...03079c5. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@seratch seratch added this to the 3.4.0 milestone May 14, 2021
@seratch seratch merged commit 1711b95 into slackapi:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactionRemovedEvent type is incorrect
4 participants