Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #925 by adding optional properties to CodedError interface #927

Merged
merged 1 commit into from
May 19, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented May 19, 2021

Summary

This pull request resolves #925 by updating the CodedError interface to have all the possible properties.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific labels May 19, 2021
@seratch seratch added this to the 3.4.0 milestone May 19, 2021
@seratch seratch self-assigned this May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #927 (f91a4bc) into main (2c1a1e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #927   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          13       13           
  Lines        1205     1205           
  Branches      355      355           
=======================================
  Hits          798      798           
  Misses        338      338           
  Partials       69       69           
Impacted Files Coverage Δ
src/errors.ts 91.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1a1e9...f91a4bc. Read the comment docs.

@seratch seratch merged commit 5185d7b into slackapi:main May 19, 2021
@seratch seratch deleted the issue-925-error-optional-fields branch May 19, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Does Not See error.original in Error Handler
2 participants