ignore casing of HTTP headers as requested by RFC (#937) #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
seratch
approved these changes
May 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 66.22% 66.19% -0.03%
==========================================
Files 13 13
Lines 1205 1207 +2
Branches 355 356 +1
==========================================
+ Hits 798 799 +1
Misses 338 338
- Partials 69 70 +1
Continue to review full report at Codecov.
|
misscoded
reviewed
May 28, 2021
src/receivers/AwsLambdaReceiver.ts
Outdated
|
|
||
| // eslint-disable-next-line class-methods-use-this | ||
| private getHeaderValue(headers: Record<string, any>, key: string): string | undefined { | ||
| const caseInsensitivKey = Object.keys(headers).find((it) => key.toLowerCase() === it.toLowerCase()); |
There was a problem hiding this comment.
Lack of e here (re: Insensitive) intentional? 😄
There was a problem hiding this comment.
thanks for pointing this out to me 🙏 and as it was not intentional I fixed it
seratch
reviewed
May 29, 2021
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug #937 that lower case headers results in errors
Requirements (place an
xin each[ ])