Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #935 enterprise_id in InstallationQuery can be invalid for Slack Connect channel events #949

Merged
merged 2 commits into from
May 31, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented May 31, 2021

Summary

Refer to #935 for details. This is a critical bug for the non-Enterprise Grid customers using Slack Connect channels.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor labels May 31, 2021
@seratch seratch added this to the 3.4.0 milestone May 31, 2021
@seratch seratch self-assigned this May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #949 (3a1aa3c) into main (0bb7ae9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          13       13           
  Lines        1207     1207           
  Branches      356      356           
=======================================
  Hits          799      799           
  Misses        338      338           
  Partials       70       70           
Impacted Files Coverage Δ
src/App.ts 82.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb7ae9...3a1aa3c. Read the comment docs.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job debugging this and sending in the fix. It can be quite challenging even reproducing these complicated cases.

@seratch seratch merged commit f009d9c into slackapi:main May 31, 2021
@seratch seratch deleted the issue-935-slack-connect-bug branch May 31, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants