-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #951 TypeScript 4.3 typing for KnownKeys<ChatPostMessageArguments>
#953
Fix #951 TypeScript 4.3 typing for KnownKeys<ChatPostMessageArguments>
#953
Conversation
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 66.19% 66.19%
=======================================
Files 13 13
Lines 1207 1207
Branches 356 356
=======================================
Hits 799 799
Misses 338 338
Partials 70 70 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokshunhung Thanks a lot for fixing this by a perfect approach 👍 Looks great to me already but let me wait for other maintainers' responses for one or two days.
We're going to release v3.4.0 within a few days and this change will be included in the version. |
It seems that there is no concern from other maintainers. Let me merge this one. Thanks again for your awesome contribution! |
Summary
This PR fixes the type
KnownKeys<ChatPostMessageArguments>
to work in TypeScript 4.3.Refer to #951 for details.
Requirements (place an
x
in each[ ]
)