Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #951 TypeScript 4.3 typing for KnownKeys<ChatPostMessageArguments> #953

Conversation

lokshunhung
Copy link
Contributor

Summary

This PR fixes the type KnownKeys<ChatPostMessageArguments> to work in TypeScript 4.3.
Refer to #951 for details.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Jun 2, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2021

CLA assistant check
All committers have signed the CLA.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific and removed untriaged labels Jun 2, 2021
@seratch seratch added this to the 3.4.0 milestone Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #953 (c0db3f8) into main (88e6790) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          13       13           
  Lines        1207     1207           
  Branches      356      356           
=======================================
  Hits          799      799           
  Misses        338      338           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e6790...c0db3f8. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokshunhung Thanks a lot for fixing this by a perfect approach 👍 Looks great to me already but let me wait for other maintainers' responses for one or two days.

@seratch
Copy link
Member

seratch commented Jun 2, 2021

We're going to release v3.4.0 within a few days and this change will be included in the version.

@seratch
Copy link
Member

seratch commented Jun 2, 2021

It seems that there is no concern from other maintainers. Let me merge this one. Thanks again for your awesome contribution!

@seratch seratch merged commit 0ec4617 into slackapi:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants