Fix #971 AwsLambdaReceiver fails to parse event.body if isBase64Encoded is true #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 66.19% 66.25% +0.05%
==========================================
Files 13 13
Lines 1207 1212 +5
Branches 356 357 +1
==========================================
+ Hits 799 803 +4
- Misses 338 339 +1
Partials 70 70
Continue to review full report at Codecov.
|
stevengill
added
enhancement
stevengill
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
Hey @TheManWhoStaresAtCode! Thanks for sending this in. Looks like a great PR. Thanks for adding a test too! I'll leave it open for a bit to give other contributors a chance to review.
seratch
approved these changes
Jun 22, 2021
| if (typeof awsEvent.body === 'undefined' || awsEvent.body == null) { | ||
| return ''; | ||
| } | ||
| if (awsEvent.isBase64Encoded) { |
There was a problem hiding this comment.
Here is the way that Bolt for Python does the same: https://github.com/slackapi/bolt-python/blob/v1.6.1/slack_bolt/adapter/aws_lambda/handler.py#L84-L85
LGTM
seratch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug when the event body is base64 encoded #971
Fixes #971
Requirements (place an
xin each[ ])