updated default axios options #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
added
bug
stevengill
commented
Jun 30, 2021
src/App.ts
Outdated
| @@ -494,14 +499,14 @@ export default class App { | |||
| ): void; | |||
| public shortcut< | |||
| Shortcut extends SlackShortcut = SlackShortcut, | |||
| Constraints extends ShortcutConstraints<Shortcut> = ShortcutConstraints<Shortcut>, | |||
There was a problem hiding this comment.
these are prettier changes I believe
There was a problem hiding this comment.
perhaps, these are the changes by your editor (VS Code). You can manually run npx prettier -w src
mwbrooks
approved these changes
Jun 30, 2021
seratch
reviewed
Jun 30, 2021
src/App.ts
Outdated
| @@ -494,14 +499,14 @@ export default class App { | |||
| ): void; | |||
| public shortcut< | |||
| Shortcut extends SlackShortcut = SlackShortcut, | |||
| Constraints extends ShortcutConstraints<Shortcut> = ShortcutConstraints<Shortcut>, | |||
There was a problem hiding this comment.
perhaps, these are the changes by your editor (VS Code). You can manually run npx prettier -w src
stevengill
force-pushed
the
axios-proxy-fix
branch
from
4e93e84 to
26e3664
Compare
stevengill
force-pushed
the
axios-proxy-fix
branch
from
26e3664 to
029ee5f
Compare
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 66.25% 66.25%
=======================================
Files 13 13
Lines 1212 1212
Branches 357 357
=======================================
Hits 803 803
Misses 339 339
Partials 70 70
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our axios instance in bolt-js won't work with some endpoints and server setups. This pr fixes this weird edgecase. We already have this fix in our web-api package. https://github.com/slackapi/node-slack-sdk/blob/main/packages/web-api/src/WebClient.ts#L138
Requirements (place an
xin each[ ])