Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak fxn behavior description #989

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Jul 5, 2021

Summary

There's a lack of clarity in the behavior described for directMention middleware built-in, as per #984. Updates the description in English. Japanese language change suggestion by @jiangem.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Jul 5, 2021
@srajiang srajiang requested a review from seratch July 5, 2021 22:24
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #989 (b305e6c) into main (6acdcfb) will not change coverage.
The diff coverage is n/a.

❗ Current head b305e6c differs from pull request most recent head a34951b. Consider uploading reports for the commit a34951b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          803      803           
  Misses        339      339           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acdcfb...a34951b. Read the comment docs.

@srajiang srajiang self-assigned this Jul 5, 2021
@srajiang srajiang added docs M-T: Documentation work only and removed untriaged labels Jul 5, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor suggestion on the Japanese language change.

docs/_advanced/ja_middleware_listener.md Outdated Show resolved Hide resolved
@seratch seratch added this to the 3.5.0 milestone Jul 5, 2021
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@srajiang srajiang merged commit 128ec42 into slackapi:main Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants