Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #985: Update "acknowledging events" code snippet #997

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Jul 8, 2021

Summary

This PR updates the code snippet in the "acknowledging events" document to use modals instead of dialogs (as dialogs are outmoded). Closes #985.

Requirements

@gitwave gitwave bot added the untriaged label Jul 8, 2021
@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Jul 8, 2021
@seratch seratch added this to the 3.5.0 milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #997 (9f5ff33) into main (7d04f5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          805      805           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d04f5d...9f5ff33. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Looks good to me 👍 The maintainers can do "Squash and merge" once the CI builds pass.

@seratch seratch merged commit 260acde into slackapi:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code snippet error in "Acknowledging events" document
2 participants