Fix #1131 A class with async "__call__" method fails to work as a middleware #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a middleware
seratch
force-pushed
the
issue-1131-async-callable
branch
from
b01d784 to
5cf5551
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 195 195
Lines 6605 6606 +1
=======================================
+ Hits 6077 6078 +1
Misses 528 528 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Aug 21, 2024
| @@ -88,3 +88,9 @@ def get_name_for_callable(func: Callable) -> str: | |||
|
|
|||
| def get_arg_names_of_callable(func: Callable) -> List[str]: | |||
| return inspect.getfullargspec(inspect.unwrap(func)).args | |||
|
|
|||
|
|
|||
| def is_coroutine_function(func: Optional[Any]) -> bool: | |||
There was a problem hiding this comment.
FYI I may rename is_coroutine_function to is_callable_coroutine in a follow up PR
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1131
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.