Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply internal adjustments for Socket Mode support #154

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 23, 2020

This pull request changes the following behaviors with the aim to support Socket Mode soon.

  • Remove signing_secret existence validation in App / AsyncApp constructor as it is not necessary for Socket Mode
  • Change request verification middleware to skip verification when a request is via Socket Mode

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.0.1 milestone Nov 23, 2020
@seratch seratch self-assigned this Nov 23, 2020
@seratch seratch merged commit 37d994a into slackapi:main Nov 24, 2020
@seratch seratch deleted the socket-mode-preps branch November 24, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant