You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you start the bot without internet connection the slack-client will emit an error 'ENOTFOUND' but the adapter currently doesn't handle it.
Currently the adapter will just log 'ERROR undefined' but it will not exit nor try to reconnect.
It'd be great if the adapter followed the HUBOT_SLACK_EXIT_ON_DISCONNECT environment option flag in this condition. If the flag is true then the adapter should exit otherwise should try and reconnect.
If others thing this is a good addition i'm happy to make a PR for it.
The text was updated successfully, but these errors were encountered:
Interesting, and worth looking into. Thanks for reporting it—I'd love a PR of course, but I'd like to wait until we have merged in the migration to node-slack-sdk v3.x
If you start the bot without internet connection the slack-client will emit an error 'ENOTFOUND' but the adapter currently doesn't handle it.
Currently the adapter will just log 'ERROR undefined' but it will not exit nor try to reconnect.
It'd be great if the adapter followed the HUBOT_SLACK_EXIT_ON_DISCONNECT environment option flag in this condition. If the flag is true then the adapter should exit otherwise should try and reconnect.
If others thing this is a good addition i'm happy to make a PR for it.
The text was updated successfully, but these errors were encountered: