Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter doesn't die when there's no connection #311

Closed
Place1 opened this issue Jun 27, 2016 · 4 comments
Closed

Adapter doesn't die when there's no connection #311

Place1 opened this issue Jun 27, 2016 · 4 comments
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@Place1
Copy link

Place1 commented Jun 27, 2016

If you start the bot without internet connection the slack-client will emit an error 'ENOTFOUND' but the adapter currently doesn't handle it.

Currently the adapter will just log 'ERROR undefined' but it will not exit nor try to reconnect.

It'd be great if the adapter followed the HUBOT_SLACK_EXIT_ON_DISCONNECT environment option flag in this condition. If the flag is true then the adapter should exit otherwise should try and reconnect.

If others thing this is a good addition i'm happy to make a PR for it.

@DEGoodmanWilson DEGoodmanWilson added possibly fixed in latest slack SDK version bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed possibly fixed in latest slack SDK version labels Jun 27, 2016
@DEGoodmanWilson
Copy link

Interesting, and worth looking into. Thanks for reporting it—I'd love a PR of course, but I'd like to wait until we have merged in the migration to node-slack-sdk v3.x

@Place1
Copy link
Author

Place1 commented Jun 28, 2016

sounds great. maybe let me know when those changes are rolled in and i'll take another look :D

@DEGoodmanWilson
Copy link

@Place1 Have a look here, would love more 👀 on this: #309

@DEGoodmanWilson
Copy link

Closing this as fixed in 4.0. Please reopen if I am mistaken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

No branches or pull requests

2 participants