Updated Logic and Tests for Slack SDK v3 support #309

johnagan · 2016-06-16T23:30:30Z

This is a first pass at adding support for v3 of the Slack SDK 💥

The core logic has been updated to use dataStore and the test stubs have been modified to support the relocation of data calls.

coveralls · 2016-06-16T23:32:55Z

Coverage decreased (-1.7%) to 58.974% when pulling e5dd2f8 on v3-sdk-updates into c0775f4 on master.

coveralls · 2016-06-17T01:39:47Z

Coverage decreased (-1.7%) to 58.974% when pulling c244c3d on v3-sdk-updates into c0775f4 on master.

coveralls · 2016-06-17T18:47:44Z

Coverage increased (+4.8%) to 65.464% when pulling cd61c60 on v3-sdk-updates into c0775f4 on master.

DEGoodmanWilson · 2016-06-20T16:52:13Z

src/slack.coffee

      token: process.env.HUBOT_SLACK_TOKEN
      autoReconnect: !exitProcessOnDisconnect
-      autoMark: true
-      exitOnDisconnect: exitProcessOnDisconnect
-      proxyUrl: process.env.https_proxy



I think the change in the options means this qualifies as a breaking change, and hence will require us to bump the major version number.

I also want to verify that the reconnection logic is working.

DEGoodmanWilson · 2016-06-20T19:39:42Z

There's another big issue: If you send a message to the bot in a public channel, it responds in a DM—always. The original responded in the same channel.

Correction. It always sends its responses to the first channel that it receives a message in since starting.

coveralls · 2016-06-20T19:53:59Z

Coverage increased (+6.6%) to 67.317% when pulling 710454c on v3-sdk-updates into c0775f4 on master.

johnagan · 2016-06-21T22:45:12Z

@DEGoodmanWilson I had to roll back your package.json commit. Looks like you overwrote it with the version from your node_modules folder 😎

coveralls · 2016-06-21T22:56:23Z

Coverage increased (+7.0%) to 67.633% when pulling 2a66fb4 on v3-sdk-updates into c0775f4 on master.

Adding additional V3 test coverage

coveralls · 2016-07-14T23:12:20Z

Coverage increased (+24.8%) to 85.507% when pulling e2fbdd6 on v3-sdk-updates into c0775f4 on master.

V4 docs

coveralls · 2016-07-15T18:35:51Z

Coverage increased (+24.8%) to 85.507% when pulling 09ba54d on v3-sdk-updates into 10fb8b7 on master.

coveralls · 2016-07-15T18:35:51Z

Coverage increased (+24.8%) to 85.507% when pulling 09ba54d on v3-sdk-updates into 10fb8b7 on master.

dnrce · 2016-07-15T19:28:13Z

🎉 👍

- Should help with sporadic disconnect issues. - See slackapi/hubot-slack#309

peritus · 2016-09-06T12:46:34Z

CHANGELOG.md

+  * Messages from bots are no longer filtered out, which is both cool and potentially terrifying, but we should never have silenced the robots in the first place.
+  * Remember how if you tried to hack on this adapter and used `npm link` to plug that into a live bot? And how that didn't work? Yeah? Well now it does. Stupid `instanceof`.
+  * Total refactoring of the functionality, exposing a slightly different interface. So watch out for that.
+  * You can now access the underlying Slack client directly, for when you really need low-level functionality therein.


Is there documentation available on how to do just that ?

.rtm or .web will return the clients.

.send is just a shortcut to select the best method.

ianfixes · 2017-01-20T15:40:41Z

If there is documentation on how to upload files or send attachments in hubot slack messages, I'm having a hard time locating it. Here's where I looked:

Support for uploading files node-slack-sdk#56
upload file #62
https://hubot.github.com/docs/scripting/
https://github.com/slackapi/hubot-slack/pull/309/files (this PR, which mentions that you can "upload" "files" but doesn't include those words anywhere in the diff)

Can someone point me to a brief example of hubot uploading a file to a slack channel?

Treyone · 2017-02-07T15:35:43Z

@ifreecarve did you find out how to upload files ? Same situation here. Thanks !

ianfixes · 2017-02-07T16:44:10Z

Elsewhere in this thread, it was noted that

.web or .rtm will return the clients.

So I assume that, worst case, you get the native client and access that method directly. Haven't tried it yet.

Treyone · 2017-02-08T08:29:14Z

Thanks, I'll give it a try !

ianfixes · 2017-02-10T13:07:46Z

I'm using robot.adapter.client.web.files.upload to access the function described here: https://api.slack.com/methods/files.upload

Treyone · 2017-02-10T17:23:25Z

Thanks ! the upload works. The binary files are however displayed as text and unreadable, but this seems to be related to another issue.

ianfixes · 2017-02-11T16:57:59Z

in contentOpts, use file: fs.createReadStream(filePath).

content: fs.readFileSync(filePath) doesn't work with binary

John Agan added 2 commits June 16, 2016 16:22

updated logic and tests to support v3 of node-slack-sdk

744359d

clean up unused functions

e5dd2f8

reverted clean up of unused functions

c244c3d

added some coveralls tests and ignores

cd61c60

DEGoodmanWilson reviewed Jun 20, 2016
View reviewed changes

No function getBody()

62062c7

Repair the missing getBody method, not updated in testing

710454c

Don Goodman-Wilson and others added 2 commits June 21, 2016 15:26

This should handle a number of the errors we've seen

7441fad

corrected package.json

d5b5cd7

fixed channel test

2a66fb4

Initial attempt at fixing #114 to correct formatting urls

7679d26

DEGoodmanWilson mentioned this pull request Jun 28, 2016

Adapter doesn't die when there's no connection #311

Closed

Don Goodman-Wilson and others added 8 commits July 14, 2016 13:27

Adding tests on receiving messages

7249c89

One more test, commiting to set it aside.

e85b67d

Fix that broken test.

1def6e8

Message handling tests

25a4b6c

Fixing some errors, writing some tests

b5683c3

There is no bot_message anymore

4f3f430

CHeck error event handling

8a21aa3

Merge pull request #321 from slackhq/v3-coverage

e2fbdd6

Adding additional V3 test coverage

Don Goodman-Wilson and others added 5 commits July 15, 2016 10:34

Updating the docs

4639968

Minor tweaks to README

2d3160e

Merge pull request #322 from slackhq/v3-docs

e71cf7c

V4 docs

Because Hubot adapters have very strict naming restrictions

e375beb

Merge branch 'master' into v3-sdk-updates

09ba54d

DEGoodmanWilson merged commit bed7406 into master Jul 15, 2016

cflee mentioned this pull request Jul 18, 2016

Upgrade hubot-slack to v4.0.0 moexmen/omega-sentinel#33

Merged

opadron added a commit to osumo/sumobot that referenced this pull request Aug 26, 2016

upgrade hubot-slack to latest version

aeaa88b

- Should help with sporadic disconnect issues. - See slackapi/hubot-slack#309

opadron mentioned this pull request Aug 26, 2016

upgrade hubot-slack to latest version osumo/sumobot#5

Merged

peritus reviewed Sep 6, 2016
View reviewed changes

aoberoi deleted the v3-sdk-updates branch July 4, 2018 00:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Logic and Tests for Slack SDK v3 support #309

Updated Logic and Tests for Slack SDK v3 support #309

johnagan commented Jun 16, 2016

coveralls commented Jun 16, 2016 •

edited

Loading

coveralls commented Jun 17, 2016 •

edited

Loading

coveralls commented Jun 17, 2016

DEGoodmanWilson Jun 20, 2016

DEGoodmanWilson Jun 20, 2016

DEGoodmanWilson commented Jun 20, 2016 •

edited

Loading

coveralls commented Jun 20, 2016

johnagan commented Jun 21, 2016

coveralls commented Jun 21, 2016 •

edited

Loading

coveralls commented Jul 14, 2016 •

edited

Loading

coveralls commented Jul 15, 2016

coveralls commented Jul 15, 2016

dnrce commented Jul 15, 2016

peritus Sep 6, 2016

johnagan Sep 6, 2016

peritus Sep 6, 2016

ianfixes commented Jan 20, 2017 •

edited

Loading

Treyone commented Feb 7, 2017

ianfixes commented Feb 7, 2017

Treyone commented Feb 8, 2017

ianfixes commented Feb 10, 2017

Treyone commented Feb 10, 2017

ianfixes commented Feb 11, 2017

Updated Logic and Tests for Slack SDK v3 support #309

Updated Logic and Tests for Slack SDK v3 support #309

Conversation

johnagan commented Jun 16, 2016

coveralls commented Jun 16, 2016 • edited Loading

coveralls commented Jun 17, 2016 • edited Loading

coveralls commented Jun 17, 2016

DEGoodmanWilson Jun 20, 2016

Choose a reason for hiding this comment

DEGoodmanWilson Jun 20, 2016

Choose a reason for hiding this comment

DEGoodmanWilson commented Jun 20, 2016 • edited Loading

coveralls commented Jun 20, 2016

johnagan commented Jun 21, 2016

coveralls commented Jun 21, 2016 • edited Loading

coveralls commented Jul 14, 2016 • edited Loading

coveralls commented Jul 15, 2016

coveralls commented Jul 15, 2016

dnrce commented Jul 15, 2016

peritus Sep 6, 2016

Choose a reason for hiding this comment

johnagan Sep 6, 2016

Choose a reason for hiding this comment

peritus Sep 6, 2016

Choose a reason for hiding this comment

ianfixes commented Jan 20, 2017 • edited Loading

Treyone commented Feb 7, 2017

ianfixes commented Feb 7, 2017

Treyone commented Feb 8, 2017

ianfixes commented Feb 10, 2017

Treyone commented Feb 10, 2017

ianfixes commented Feb 11, 2017

coveralls commented Jun 16, 2016 •

edited

Loading

coveralls commented Jun 17, 2016 •

edited

Loading

DEGoodmanWilson commented Jun 20, 2016 •

edited

Loading

coveralls commented Jun 21, 2016 •

edited

Loading

coveralls commented Jul 14, 2016 •

edited

Loading

ianfixes commented Jan 20, 2017 •

edited

Loading