Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Logic and Tests for Slack SDK v3 support #309

Merged
merged 46 commits into from
Jul 15, 2016
Merged

Updated Logic and Tests for Slack SDK v3 support #309

merged 46 commits into from
Jul 15, 2016

Commits on Jun 16, 2016

  1. updated logic and tests to support v3 of node-slack-sdk

    John Agan committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    744359d View commit details
    Browse the repository at this point in the history

  2. clean up unused functions

    John Agan committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    e5dd2f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2016

  1. reverted clean up of unused functions

    John Agan committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    c244c3d View commit details
    Browse the repository at this point in the history

  2. added some coveralls tests and ignores

    John Agan committed Jun 17, 2016
    Configuration menu
    Copy the full SHA
    cd61c60 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2016

  1. No function getBody()

    Don Goodman-Wilson committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    62062c7 View commit details
    Browse the repository at this point in the history

  2. Repair the missing getBody method, not updated in testing

    Don Goodman-Wilson committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    710454c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2016

  1. This should handle a number of the errors we've seen

    Don Goodman-Wilson committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    7441fad View commit details
    Browse the repository at this point in the history

  2. corrected package.json

    John Agan committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    d5b5cd7 View commit details
    Browse the repository at this point in the history

  3. fixed channel test

    John Agan committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    2a66fb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2016

  1. Initial attempt at fixing #114 to correct formatting urls

    John Agan committed Jun 27, 2016
    1 Configuration menu
    Copy the full SHA
    7679d26 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2016

  1. an attempt at rewriting to have better support for complex messages a… 

    …nd events
    John Agan committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    900402e View commit details
    Browse the repository at this point in the history

  2. adjusted method names

    John Agan committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    93d01dc View commit details
    Browse the repository at this point in the history

  3. adjusted method names

    John Agan committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    0224285 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #314 from slackhq/hubot-v4-proto 

    Prototype for Hubot v4 with Slack SDK v3 Support
    Don Goodman-Wilson authored Jul 1, 2016
    Configuration menu
    Copy the full SHA
    09514bf View commit details
    Browse the repository at this point in the history

  5. Fix errors handling message with un-handled subtypes that may or may … 

    …not include a user field.
    Don Goodman-Wilson committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    9153bf5 View commit details
    Browse the repository at this point in the history

  6. Getting at least some of the tests to pass. This is terrible.

    Don Goodman-Wilson committed Jul 1, 2016
    Configuration menu
    Copy the full SHA
    4e078ac View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2016

  1. Tests are running...and passing!

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    aef4233 View commit details
    Browse the repository at this point in the history

  2. Look at that, so many green lights.

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    12bcff4 View commit details
    Browse the repository at this point in the history

  3. All original passing tests are now in and passing.

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    705ffd2 View commit details
    Browse the repository at this point in the history

  4. Fixing Silliness

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    ad68cdd View commit details
    Browse the repository at this point in the history

  5. Don't need that! Doesn't work in the stub anyway.

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    3bfdc18 View commit details
    Browse the repository at this point in the history

  6. This is an experiment

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    341e54d View commit details
    Browse the repository at this point in the history

  7. Make this node 0.10 compatible

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    8a8d19d View commit details
    Browse the repository at this point in the history

  8. Merge pull request #315 from slackhq/v3-sdk-updates-writing-tests 

    V3 sdk updates writing tests
    Don Goodman-Wilson authored Jul 5, 2016
    Configuration menu
    Copy the full SHA
    09d4dd6 View commit details
    Browse the repository at this point in the history

  9. More tests on SlackFormatter, and a bug fix!

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    306142b View commit details
    Browse the repository at this point in the history

  10. Clean up beforeEach triggers

    Don Goodman-Wilson committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    d3e7f53 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2016

  1. Adding tests for client

    @gtr32x
    gtr32x committed Jul 8, 2016
    Configuration menu
    Copy the full SHA
    48de700 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2016

  1. Filling in the remainder of the tests for client

    @gtr32x
    gtr32x committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    881b5a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2016

  1. Updating package.json to reflect future reality

    Don Goodman-Wilson committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    2aab972 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. added robot logger coverage

    John Agan committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    d93be77 View commit details
    Browse the repository at this point in the history

  2. Making the tests a little more specific.

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    3e6ae9e View commit details
    Browse the repository at this point in the history

  3. Tests around replying...and found a bug

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    43d3c65 View commit details
    Browse the repository at this point in the history

  4. Small victories

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    179b424 View commit details
    Browse the repository at this point in the history

  5. Adding tests on receiving messages

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    7249c89 View commit details
    Browse the repository at this point in the history

  6. One more test, commiting to set it aside.

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    e85b67d View commit details
    Browse the repository at this point in the history

  7. Fix that broken test.

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    1def6e8 View commit details
    Browse the repository at this point in the history

  8. Message handling tests

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    25a4b6c View commit details
    Browse the repository at this point in the history

  9. Fixing some errors, writing some tests

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    b5683c3 View commit details
    Browse the repository at this point in the history

  10. There is no bot_message anymore

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    4f3f430 View commit details
    Browse the repository at this point in the history

  11. CHeck error event handling

    Don Goodman-Wilson committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    8a21aa3 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #321 from slackhq/v3-coverage 

    Adding additional V3 test coverage
    Don Goodman-Wilson authored Jul 14, 2016
    Configuration menu
    Copy the full SHA
    e2fbdd6 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. Updating the docs

    Don Goodman-Wilson committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    4639968 View commit details
    Browse the repository at this point in the history

  2. Minor tweaks to README

    Don Goodman-Wilson committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    2d3160e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #322 from slackhq/v3-docs 

    V4 docs
    Don Goodman-Wilson authored Jul 15, 2016
    Configuration menu
    Copy the full SHA
    e71cf7c View commit details
    Browse the repository at this point in the history

  4. Because Hubot adapters have very strict naming restrictions

    Don Goodman-Wilson committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    e375beb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into v3-sdk-updates

    Don Goodman-Wilson committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    09ba54d View commit details
    Browse the repository at this point in the history