Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing event data types #1332

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Jul 2, 2024

While auditing the latest updates on the platform, I found that a few events are not yet supported in this SDK.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-model project:slack-api-model project:slack-app-backend labels Jul 2, 2024
@seratch seratch added this to the 1.40.2 milestone Jul 2, 2024
@seratch seratch self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.95%. Comparing base (2bae6fb) to head (ad2d6ec).

Files Patch % Lines
.../app_backend/events/handler/AppDeletedHandler.java 0.00% 2 Missing ⚠️
...pp_backend/events/handler/AppInstalledHandler.java 0.00% 2 Missing ⚠️
...kend/events/handler/AppUninstalledTeamHandler.java 0.00% 2 Missing ⚠️
...ackend/events/handler/FunctionExecutedHandler.java 0.00% 2 Missing ⚠️
...s/handler/SharedChannelInviteRequestedHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1332      +/-   ##
============================================
- Coverage     75.02%   74.95%   -0.07%     
+ Complexity     4187     4186       -1     
============================================
  Files           446      451       +5     
  Lines         12920    12930      +10     
  Branches       1331     1331              
============================================
- Hits           9693     9692       -1     
- Misses         2455     2466      +11     
  Partials        772      772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,13 @@
package com.slack.api.app_backend.events.handler;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These handlers are legacy ones (meaning these are not used in bolt-java), but I've added them this time. In the future, we may want to deprecate them since v2.

@seratch
Copy link
Member Author

seratch commented Jul 2, 2024

FYI for reviewers, all you need to do for Events API are 1) add event classes 2) add payload wrapper classes. Once they are added, you can refer to them in bolt-java without any changes on bolt-java side.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@seratch seratch merged commit 0745ad5 into slackapi:main Jul 3, 2024
5 of 6 checks passed
@seratch seratch deleted the add-missing-events branch July 3, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-api-model project:slack-api-model project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants