-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing event data types #1332
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
============================================
- Coverage 75.02% 74.95% -0.07%
+ Complexity 4187 4186 -1
============================================
Files 446 451 +5
Lines 12920 12930 +10
Branches 1331 1331
============================================
- Hits 9693 9692 -1
- Misses 2455 2466 +11
Partials 772 772 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,13 @@ | |||
package com.slack.api.app_backend.events.handler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These handlers are legacy ones (meaning these are not used in bolt-java), but I've added them this time. In the future, we may want to deprecate them since v2.
FYI for reviewers, all you need to do for Events API are 1) add event classes 2) add payload wrapper classes. Once they are added, you can refer to them in bolt-java without any changes on bolt-java side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
While auditing the latest updates on the platform, I found that a few events are not yet supported in this SDK.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.