Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket Mode support #616 #633

Merged
merged 13 commits into from
Jan 12, 2021
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 23, 2020

This pull request fixes #616 Socket Mode support in the SDK and Bolt framework.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client labels Nov 23, 2020
@seratch seratch requested a review from stevengill November 23, 2020 23:22
@seratch seratch self-assigned this Nov 23, 2020
@seratch seratch force-pushed the issue-616-socket-mode branch from 29d5941 to a1957c3 Compare November 24, 2020 08:13
@seratch seratch added this to the 1.5.0 milestone Nov 24, 2020
@seratch seratch force-pushed the issue-616-socket-mode branch from a1957c3 to a3eef4d Compare December 2, 2020 03:53
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #633 (0ec9a13) into main (d9cb754) will decrease coverage by 0.74%.
The diff coverage is 69.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #633      +/-   ##
============================================
- Coverage     79.47%   78.72%   -0.75%     
- Complexity     2898     3041     +143     
============================================
  Files           321      327       +6     
  Lines          8238     8822     +584     
  Branches        771      833      +62     
============================================
+ Hits           6547     6945     +398     
- Misses         1222     1368     +146     
- Partials        469      509      +40     
Impacted Files Coverage Δ Complexity Δ
...i/bolt/middleware/builtin/RequestVerification.java 90.90% <0.00%> (-9.10%) 5.00 <3.00> (ø)
...slack/api/methods/impl/AsyncMethodsClientImpl.java 93.94% <0.00%> (-0.50%) 348.00 <0.00> (ø)
...-api-client/src/main/java/com/slack/api/Slack.java 69.67% <38.88%> (-5.33%) 36.00 <4.00> (+4.00) ⬇️
...va/com/slack/api/bolt/util/SlackRequestParser.java 65.65% <47.36%> (-5.94%) 21.00 <19.00> (+1.00) ⬇️
bolt/src/main/java/com/slack/api/bolt/App.java 65.13% <50.00%> (-0.20%) 116.00 <0.00> (ø)
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 61.70% <61.70%> (ø) 32.00 <32.00> (?)
...va/com/slack/api/socket_mode/SocketModeClient.java 67.76% <67.76%> (ø) 37.00 <37.00> (?)
...pi/socket_mode/impl/SocketModeClientTyrusImpl.java 73.12% <73.12%> (ø) 44.00 <44.00> (?)
.../com/slack/api/bolt/socket_mode/SocketModeApp.java 78.33% <78.33%> (ø) 12.00 <12.00> (?)
...t/socket_mode/request/SocketModeRequestParser.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cb754...0ec9a13. Read the comment docs.

@seratch seratch force-pushed the issue-616-socket-mode branch from b04696f to 17939cd Compare December 8, 2020 13:51
@seratch seratch changed the title WIP: Socket Mode support #616 Socket Mode support #616 Jan 6, 2021
@seratch seratch marked this pull request as ready for review January 6, 2021 04:48
@seratch seratch force-pushed the issue-616-socket-mode branch 2 times, most recently from 3243629 to 36e012d Compare January 6, 2021 14:11
@seratch seratch force-pushed the issue-616-socket-mode branch from e55e726 to 9fd3692 Compare January 8, 2021 23:54
@seratch
Copy link
Member Author

seratch commented Jan 9, 2021

@seratch seratch merged commit b2dd570 into slackapi:main Jan 12, 2021
@seratch seratch deleted the issue-616-socket-mode branch January 12, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket Mode
1 participant