Add more event data to event listener arguments; fix #1205 too #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
seratch
commented
Aug 26, 2021
filmaj
approved these changes
Aug 26, 2021
|
Before merging this, we need to fix the errors with the latest TS compiler. |
seratch
force-pushed
the
socket-mode-more-event-data
branch
from
fba554c to
1580daf
Compare
|
I've rebased on the main branch. Once the CI builds pass, we will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds more properties to the event listener arguments. The main motivation is to add retry num & retry reason to bolt-js's
ReceiverEventdata as part of slackapi/bolt-js#759This pull request fixes #1205 as it adds the first-ever unit tests to socket-mode package project.
Requirements (place an
xin each[ ])