cli-test: Update for Windows e2e tests #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
==========================================
+ Coverage 81.85% 88.73% +6.88%
==========================================
Files 35 18 -17
Lines 7781 6232 -1549
Branches 318 298 -20
==========================================
- Hits 6369 5530 -839
+ Misses 1400 690 -710
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
vegeris
force-pushed
the
evegeris_windows_cci
branch
4 times, most recently
from
877051e to
9a12202
Compare
vegeris
force-pushed
the
evegeris_windows_cci
branch
2 times, most recently
from
125462c to
aa29a2f
Compare
vegeris
force-pushed
the
evegeris_windows_cci
branch
from
aa29a2f to
34f29a1
Compare
vegeris
commented
Jul 18, 2024
| @@ -203,6 +203,9 @@ export const shell = { | |||
| }, | |||
| assembleShellEnv: function assembleShellEnv(): Record<string, string | undefined> { | |||
| const spawnedEnv = { ...process.env }; | |||
| if (process.platform === "win32"){ | |||
| spawnedEnv.PATH = process.env.PATH; | |||
There was a problem hiding this comment.
IIRC Without this the process couldn't find cmd.exe on the path for some reason
filmaj
approved these changes
Jul 18, 2024
| @@ -203,6 +203,9 @@ export const shell = { | |||
| }, | |||
| assembleShellEnv: function assembleShellEnv(): Record<string, string | undefined> { | |||
| const spawnedEnv = { ...process.env }; | |||
| if (process.platform === "win32"){ | |||
| spawnedEnv.PATH = process.env.PATH; | |||
vegeris
force-pushed
the
evegeris_windows_cci
branch
from
34f29a1 to
507fac8
Compare
vegeris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Windows e2e tests can be seen running successfully in CCI consuming these changes: https://app.circleci.com/pipelines/github/slackapi/slack-cli/6390/workflows/31d009e1-6a81-46d2-bec6-c7ace7268fe0/jobs/15343 (failing 'copy artifacts' steps unrelated)
Sanity checked that the Unix e2e tests still pass here: https://app.circleci.com/pipelines/github/slackapi/platform-devxp-test/395/workflows/9cedbc0e-db05-4bf3-bad9-a188d28583c8/jobs/625?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
Requirements