Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth(fix): remove double quotes from the default 'add to slack' img alt text #2044

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Sep 28, 2024

Summary

This PR mirrors the changes contributed in slackapi/bolt-python#1170 🙏

Requirements

@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch pkg:oauth applies to `@slack/oauth-helper` labels Sep 28, 2024
@zimeg zimeg added this to the oauth@3.0.2 milestone Sep 28, 2024
@zimeg zimeg self-assigned this Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (0861218) to head (b4c77a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   92.51%   91.66%   -0.86%     
==========================================
  Files          37       37              
  Lines        9981     9981              
  Branches      631      631              
==========================================
- Hits         9234     9149      -85     
- Misses        747      820      +73     
- Partials        0       12      +12     
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 95.39% <ø> (-0.61%) ⬇️
oauth 77.39% <100.00%> (-4.13%) ⬇️
socket-mode 58.22% <ø> (-0.86%) ⬇️
web-api 96.89% <ø> (-0.40%) ⬇️
webhook 96.65% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@zimeg
Copy link
Member Author

zimeg commented Sep 28, 2024

I wanted to double check once more that the HTML being updated is invalid and I can confirm this is true in at least Safari.

A double quoted alt text is the same as something like this (if I'm understanding the first equal to be the quoted string right):

- <img alt=""example"" />
+ <img alt="" />

Going to hold off on merging this right now, but I noticed a similar change will also be needed in Bolt for Java 👀

@zimeg
Copy link
Member Author

zimeg commented Sep 28, 2024

The failing codecov check is also caused by a change to indirect coverage unrelated to this PR. However, I am open to including tests for this change if a specific check makes sense 🤔

@filmaj filmaj merged commit ee8411a into slackapi:main Sep 29, 2024
29 of 30 checks passed
@zimeg zimeg deleted the oauth-fix-alt-text-quotes branch September 29, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:oauth applies to `@slack/oauth-helper` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants