Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the example respond when "Hello." is said instead of every message #337

Merged
merged 1 commit into from
May 17, 2017
Merged

Make the example respond when "Hello." is said instead of every message #337

merged 1 commit into from
May 17, 2017

Conversation

CodeFoodPixels
Copy link
Contributor

  • ☑️ I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • ☑️ I've read and agree to the Code of Conduct.
  • ☑️ I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • ☑️ I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • [N/A] I've written tests to cover the new code and functionality included in this PR.
  • ☑️ I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Correcting the example in the docs to only respond to the user when they say "Hello." as described by the text above it.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 18, 2017

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   85.72%   85.72%           
=======================================
  Files          44       44           
  Lines        1198     1198           
  Branches      176      176           
=======================================
  Hits         1027     1027           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652e68b...b555c33. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented May 16, 2017

Hi @lukeb-uk, sorry for not getting to this PR for so long. Can I ask why you'd like to limit the responses to just when someone says "Hello."?

I could see actually using this example as being problematic because it would essentially spam your #general channel, but that's not really the intention. The way I see it, the example is meant to illustrate how to use the SDK with as little extra logic as possible. But since I don't expect people to run the example for more than a few seconds to verify that it works, I think its not necessary to filter the messages.

@CodeFoodPixels
Copy link
Contributor Author

I was just correcting the example to do what the text above it said it was actually doing.

@aoberoi
Copy link
Contributor

aoberoi commented May 17, 2017

oh, you're absolutely right. i missed that. thanks!

@aoberoi aoberoi merged commit c42de6e into slackapi:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants