Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the validate argument in the channels.join method optional #530

Merged
merged 3 commits into from
Apr 13, 2018

Conversation

DominikPalo
Copy link
Contributor

@DominikPalo DominikPalo commented Apr 12, 2018

Summary

The validate argument in the channels.join method is optional (see https://api.slack.com/methods/channels.join), therefore it should be marked as optional also in the associated type.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files           6        6           
  Lines         279      279           
  Branches       43       43           
=======================================
  Hits          222      222           
  Misses         39       39           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bed1fc...561d523. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented Apr 13, 2018

thanks for finding this inconsistency!

@aoberoi aoberoi merged commit fb19909 into slackapi:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants