Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include email as user property #113

Closed
wants to merge 1 commit into from
Closed

include email as user property #113

wants to merge 1 commit into from

Conversation

acaire
Copy link
Contributor

@acaire acaire commented Jul 26, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Our use case entails having Slack as a source of truth for users, so we'd like to keep track of user e-mail addresses. This PR adds an email property to the user object.

@coveralls
Copy link

coveralls commented Jul 26, 2016

Coverage Status

Coverage increased (+0.06%) to 61.328% when pulling 55da0ea on acaire:master into c36dbf4 on slackhq:master.

@ghTravis
Copy link

ghTravis commented Feb 16, 2017

I'm also looking for this functionality!
+1

@acaire
Copy link
Contributor Author

acaire commented Mar 8, 2017

Closing in favour of #173 due to deleted fork

@acaire acaire closed this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants