Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain to team.info API parameters #1195

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 3, 2022

Summary

This pull request adds domain parameter to the team.info API method.

The team.info parameter domain is now public. Query for your team's information by domain only when team is null.
https://api.slack.com/changelog

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Apr 3, 2022
@seratch seratch added this to the 3.15.3 milestone Apr 3, 2022
@seratch seratch self-assigned this Apr 3, 2022
@seratch seratch force-pushed the team-info-domain branch from cda35f5 to 711343a Compare April 3, 2022 21:44
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1195 (711343a) into main (b3cb02a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   86.54%   86.51%   -0.03%     
==========================================
  Files         110      110              
  Lines       10872    10872              
==========================================
- Hits         9409     9406       -3     
- Misses       1463     1466       +3     
Impacted Files Coverage Δ
slack_sdk/web/async_client.py 85.08% <100.00%> (ø)
slack_sdk/web/client.py 86.47% <100.00%> (ø)
slack_sdk/web/legacy_client.py 86.18% <100.00%> (ø)
slack_sdk/socket_mode/builtin/internals.py 71.05% <0.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cb02a...711343a. Read the comment docs.

Comment on lines +3907 to +3913
domain: Optional[str] = None,
**kwargs,
) -> Union[Future, SlackResponse]:
"""Gets information about the current team.
https://api.slack.com/methods/team.info
"""
kwargs.update({"team": team})
kwargs.update({"team": team, "domain": domain})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻 Nice for legacy!

@seratch seratch merged commit f9d52a4 into slackapi:main Apr 4, 2022
@seratch seratch deleted the team-info-domain branch April 4, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants