health: move to mypy #1620
Open
health: move to mypy #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBergamin
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
+ Coverage 85.03% 85.06% +0.03%
==========================================
Files 113 113
Lines 12661 12658 -3
==========================================
+ Hits 10766 10768 +2
+ Misses 1895 1890 -5 ☔ View full report in Codecov by Sentry. |
seratch
approved these changes
Dec 23, 2024
| placeholder=placeholder, | ||
| ) | ||
| self.min_query_length = min_query_length | ||
|
|
||
|
|
||
| class DialogBuilder(JsonObject): | ||
| attributes = {} # no attributes because to_dict has unique implementation | ||
| attributes = set() # no attributes because to_dict has unique implementation |
There was a problem hiding this comment.
It seems this property is unused, so changing the type should not affect the behavior. That said, changing from dict to set object may not make sense. This legacy component won't be enhanced anymore but using a set object might be a cause of future bugs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to follow the Bolt Pythons #1130
MyPy was found to execute much fast the PyType in this project, these changes adapt the project to use MyPy instead of PyType
From my short experience with mypy:
Note: removing all the type: ignore comments from the project may cause breaking changes or have a ripple effect through the entire project
Testing
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.