Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused exception class, fixes #227 #233

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

Roach
Copy link
Contributor

@Roach Roach commented Oct 3, 2017

Summary

Fixes #227
Removing an unused exception class, which is also misspelled.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #233 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   59.61%   59.35%   -0.27%     
==========================================
  Files           9        9              
  Lines         312      310       -2     
  Branches       57       57              
==========================================
- Hits          186      184       -2     
  Misses        112      112              
  Partials       14       14
Impacted Files Coverage Δ
slackclient/server.py 58.4% <ø> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410f38a...3b16d8b. Read the comment docs.

@Roach Roach merged commit 661fc5c into master Oct 3, 2017
@Roach Roach mentioned this pull request Nov 22, 2017
2 tasks
@RodneyU215 RodneyU215 deleted the roach/remove-unused-exception branch May 7, 2019 20:31
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants