Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Error #245

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Fix Build Error #245

merged 2 commits into from
Nov 20, 2017

Conversation

stasfilin
Copy link
Contributor

@stasfilin stasfilin commented Nov 20, 2017

Summary

Fix flake8 errors.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@3ccd408). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage          ?   59.62%           
=========================================
  Files             ?        9           
  Lines             ?      317           
  Branches          ?       58           
=========================================
  Hits              ?      189           
  Misses            ?      113           
  Partials          ?       15
Impacted Files Coverage Δ
slackclient/client.py 37.93% <0%> (ø)
slackclient/server.py 58.77% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccd408...5cb07b5. Read the comment docs.

@Roach Roach merged commit 422e96f into slackapi:master Nov 20, 2017
@stasfilin stasfilin deleted the fix_build_error branch November 20, 2017 22:47
@Roach Roach mentioned this pull request Nov 22, 2017
2 tasks
lavabyrd pushed a commit that referenced this pull request Apr 25, 2019
* fix build errors

* change to except Exception
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
* fix build errors

* change to except Exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants