Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indentation of Code Snippets in README.md #525

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

abhishekjiitr
Copy link
Contributor

@abhishekjiitr abhishekjiitr commented Oct 4, 2019

Summary

Fix Indentation of Code Snippets in README.md and make it consistent with other usage which has correct indentation.

3 out of 5 total code snippets have extra indentation added, which is not consitent with the two other snippets with seemingly correct indentation in README.md

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          15       15           
  Lines        1707     1707           
  Branches       96       96           
=======================================
  Hits         1176     1176           
  Misses        508      508           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 128305a...53014ea. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just in case, I would like @RodneyU215 to check and merge this.

@RodneyU215
Copy link
Contributor

Thanks for the PR @abhishekjiitr! This looks good to me as well.

@RodneyU215 RodneyU215 merged commit d9183dc into slackapi:master Oct 5, 2019
@RodneyU215 RodneyU215 mentioned this pull request Oct 8, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants