Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #670 by removing all None values from dict #671

Merged
merged 1 commit into from
May 11, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 7, 2020

Summary

This pull request fixes #670 by scanning None values from data, files, and params. There is no reason to keep them as they'll just result in TypeError.

After applying this change, the new sync mode WebClient in #662 also needs to be updated in the same manner.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client v2.6 in-progress labels May 7, 2020
@seratch seratch added this to the 2.6.0 milestone May 7, 2020
@seratch seratch self-assigned this May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #671 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   87.17%   87.21%   +0.04%     
==========================================
  Files          15       15              
  Lines        1824     1830       +6     
  Branches      100      106       +6     
==========================================
+ Hits         1590     1596       +6     
  Misses        202      202              
  Partials       32       32              
Impacted Files Coverage Δ
slack/web/base_client.py 80.86% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1247588...53b1a46. Read the comment docs.

@seratch
Copy link
Member Author

seratch commented May 11, 2020

This is safe enough. Let me merge this now.

@seratch seratch merged commit ebaa9bc into slackapi:master May 11, 2020
@seratch seratch deleted the issue-670 branch May 11, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running 'files_upload' with 'titile=None', TypeError is occurred.
1 participant