Add style to confirm in a block element #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
Version: 2x
enhancement
|
Related to slackapi/node-slack-sdk#1022 |
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 85.59% 85.55% -0.04%
==========================================
Files 19 19
Lines 2631 2638 +7
Branches 252 253 +1
==========================================
+ Hits 2252 2257 +5
- Misses 285 286 +1
- Partials 94 95 +1
Continue to review full report at Codecov.
|
seratch
commented
May 22, 2020
| @@ -315,6 +322,8 @@ def to_dict(self, option_type: str = "block") -> dict: | |||
| json["confirm"] = self._confirm.to_dict() | |||
| if self._deny: | |||
| json["deny"] = self._deny.to_dict() | |||
| if self._style: | |||
There was a problem hiding this comment.
style is available only for blocks, not for attachments.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the missing
confirm.stylein block elements.https://api.slack.com/reference/block-kit/composition-objects#confirm
Requirements (place an
xin each[ ])