Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #901 by correcting type hints for files_upload method args #909

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 5, 2021

Summary

This pull request fixes #901 by correcting the file arg's type hint.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (Web API client)
  • slack_sdk.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.rtm.RTMClient (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Jan 5, 2021
@seratch seratch added this to the 3.1.1 milestone Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #909 (a805288) into main (0a25de9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          35       35           
  Lines        3381     3381           
=======================================
  Hits         2557     2557           
  Misses        824      824           
Impacted Files Coverage Δ
slack_sdk/web/legacy_client.py 35.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a25de9...a805288. Read the comment docs.

@seratch seratch force-pushed the issue-901-files_upload_type-hint branch from 81d38fd to a805288 Compare January 5, 2021 08:28
@seratch seratch merged commit e5b1a73 into slackapi:main Jan 5, 2021
@seratch seratch deleted the issue-901-files_upload_type-hint branch January 5, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type hint for WebClient#files_upload file argument
2 participants