-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Added support for Incoming Webhook #12
Conversation
Pleaaaase Hurry up ! :) |
Did you forget to build it? I'm looking forward to this PR being merged. Thanks. |
Any update on this? /cc @stevengill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but as I mentioned at #11 (comment), I would like to wait for @stevengill's review for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed that the current implementation support only Workflow Builder webhook use cases. To support both webhooks for posting a message nad webhooks for triggering a workflow, perhaps, we need to:
- have a new option to determine the webhook type
- dispatch the logic accordingly (=the workflow webhook pattern should be supported too)
Agree with @seratch. I left a comment on the open issue. We don't want to remove flatten from the library but want to introduce a fork for incoming_webhook support. |
…t flattened objects" This reverts commit 41b013d.
cc'ing: @seratch @stevengill
(phew) P. S. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Please wait for @stevengill's review before starting to modify this PR
@seratch changes look good to me, thanks for the review, waiting for confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Summary
Closes #11 Advanced messages fails issue, because slack only accepts not flattened parameters and payload doesn't reach workflow builder afterwards.
Requirements