Bump node from 12 to 16 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mwbrooks
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Thanks @quinnjn! We were just discussing bumping all of the Slack node projects from 12 to 16, so this PR is greatly appreciated!
I've left a small nit/question but it looks good to me. I've added a few other maintainer's who are active on this project to approve the PR before we move forward.
srajiang
approved these changes
Sep 14, 2022
mwbrooks
added
dependencies
filmaj
approved these changes
Sep 15, 2022
|
Beauty @quinnjn 👌🏻 Thanks for the changes and you've got ✅ ✅ ✅ all around! I've merged the pull request and we'll put together a release soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps node12 to node16. Also suggesting at least node 16 for install. Node 12 is EOL.
Requirements (place an
xin each[ ])