Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payload integration test to escape invalid characters #207

Merged
merged 1 commit into from
May 31, 2023

Conversation

hello-ashleyintech
Copy link
Contributor

Summary

With testing #205, in the PR #206 to make sure the integration tests run, it was determined that the toJSON() in the payload integration test doesn't seem to work to parse the body of a given PR if it contains characters that need to be escaped within a string (example error output can be found in this test run).

However, there is a workaround for this in which bash automatically escapes invalid characters in env variables (see this issue for more info). This PR adds in this workaround so that all future PRs will successfully parse as JSON, regardless of the contents of the PR description. After adding this testing update in the test integration PR, the payload integration test ran successfully.

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech merged commit 9df6813 into main May 31, 2023
@hello-ashleyintech hello-ashleyintech deleted the ah-update-payload-test branch May 31, 2023 16:07
PhuongTMR pushed a commit to PhuongTMR/slack-github-action that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants