-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for developing with a local version of the action #250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; it seems the CI builds are failing now although perhaps your changes are unrelated
|
||
**Requirements**: | ||
|
||
- An installation of [nektos/act](https://github.com/nektos/act) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know this tool 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good additions 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but yeah we should check the integration test failures
@seratch @WilliamBergamin @filmaj Thank y'all for the reviews! The failing integration tests are strange, but I believe this is caused by this PR coming from a fork. From the "Actions" tab in settings:
It looks like there's a workaround that requires some additions to the workflow file, which might be useful for future contributions! I'll open a new issue to track changes around this, but since this PR doesn't change current behaviors I think it's fine to merge as is. |
Hmm that is odd. Usually there is a 'allow the tests to run for this PR' in the case that the PR comes from a fork. |
Going to merge this as is since I believe the integration tests are failing due to secrets not being shared with actions run by forks, not from the changes within. Will quickly revert it if failures continue, but continuing research into the failed integration tests in #258 🔍 |
Summary
This PR introduces instructions for developing with a local version of the action to improve the development experience. No longer are pushes and tags to a remote branch necessary.
These changes allow custom configurations to be made to the event payloads to test various cases, and different techniques can be tried with changes to the
local.yml
file.At the moment only a simple
payload
is provided to mock Technique 1. I think this is alright to start as more events could be added over time, or experiments can just be performed locally.Open to any thoughts on this!
Requirements