Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Quote #26

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add Missing Quote #26

merged 1 commit into from
Dec 7, 2021

Conversation

ChunkLightTuna
Copy link
Contributor

@ChunkLightTuna ChunkLightTuna commented Nov 19, 2021

Summary

Add Missing Quote. Also the values key on line 45 does not appear to be valid, but I'm new to GH actions and possibly missing something.

Requirements (place an x in each [ ])

Also the values key on line 45 does not appear to be valid, but I'm new to GH actions and posibly missing something.
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021

CLA assistant check
All committers have signed the CLA.

@seratch
Copy link
Member

seratch commented Nov 19, 2021

Hi @ChunkLightTuna, thanks for submitting this pull request!

The change looks great to me. Would you mind signing our CLA? (check the above bot message) Without having it, we are unable to merge your contribution 🙇

@mwbrooks mwbrooks added the documentation Improvements or additions to documentation label Nov 22, 2021
@seratch seratch added this to the 1.17 milestone Nov 24, 2021
@seratch
Copy link
Member

seratch commented Nov 24, 2021

Hi @ChunkLightTuna, can you check my above comment?

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing the CLA! LGTM again

@seratch seratch merged commit 105d27e into slackapi:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants