-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated CI to use latest version of this action when running tests #32
Conversation
f5cb74d
to
a9c1261
Compare
67e2732
to
4027ce2
Compare
Alright, this is ready for a review @filmaj @seratch I broke out the botToken and webhook integration tests into their own jobs. Added a job for unit tests. The webhook job does some normalizing of the github paylods (between push and pull request) and sends the normalized object to workflow builder. A pretty nice usecase to share I think. We may want to add a unit test + integration test for incoming webhook as well here. |
Also, @filmaj the unit test job outputs the entire payload of the event. I feel like this shouldn't be happening. See the |
4027ce2
to
fce05eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
8b030fa
to
67420c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is awesome! Love the integration test jobs you wrote up, left a few comments on potential tweaks.
As for the unit test output, I believe this is happening because in one of the error paths in the code for the action, we console.log
the entire payload, which itself may be loaded from a GitHub Action event (which furthermore comes in via the @actions/github
module). So in our situation here: since the CI for this Action is itself running via GitHub Actions, the relevant GitHub-Actions-specific environment variables are present, so the pull request GitHub event payload info is loaded up when running the unit tests in CI 😆
We could comment out the console.log
in the error path as one potential solution. Or leave it as-is. I don't think it's a big deal either way. The unit tests exercise that error path, so I think it is expected.
Co-authored-by: Fil Maj <maj.fil@gmail.com>
Summary
updated CI to use latest version of this action when running tests
Requirements (place an
x
in each[ ]
)