Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linting and unit tests #34

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Adding linting and unit tests #34

merged 1 commit into from
Nov 24, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Nov 24, 2021

Summary

Adding first pass linting and basic unit tests.

@filmaj
Copy link
Contributor Author

filmaj commented Nov 24, 2021

FYI I have not integrated this into the GitHub workflow file as I believe @stevengill is working on revamping that. So, after that lands, we can integrate running the tests into the CI by making sure the workflow runs npm test.

@seratch seratch added this to the 1.17 milestone Nov 24, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Left a comment about the eslint warnings

src/slack-send.js Show resolved Hide resolved
@stevengill stevengill merged commit fd05709 into main Nov 24, 2021
@stevengill stevengill deleted the unit-tests branch November 24, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants