Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#43] Add payload file path to enhance the github action. #44

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

umbertix
Copy link
Contributor

@umbertix umbertix commented Dec 17, 2021

Fixes: #43

Increase code coverage.
Updated Readme to have the new input type.
Added example for the new input type usage.

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

Increase code coverage.
Updated Readme to have the new input type.
Added example for the new input type usage.
@umbertix umbertix changed the title Add payload file path to enhance the github action. [#43] Add payload file path to enhance the github action. Dec 17, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@srajiang srajiang added the enhancement New feature or request label Dec 17, 2021
.github/resources/payload-notification.json Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/slack-send.js Outdated Show resolved Hide resolved
src/slack-send.js Outdated Show resolved Hide resolved
test/slack-send-test.js Outdated Show resolved Hide resolved
@seratch seratch added this to the 1.17 milestone Dec 21, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for working on this!

@seratch
Copy link
Member

seratch commented Jan 6, 2022

@stevengill If this change looks good to you, you can merge this 👍 (let's use "Squash and merge" to squash the commits into one)

@umbertix
Copy link
Contributor Author

I don't have enough permissions to merge. I believe you'll have to do the honors.

@seratch
Copy link
Member

seratch commented Jan 10, 2022

@umbertix Thanks for being patient here! My last comment was to Steve, another maintainer of this repo. I wanted to have his review before merging this PR.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!!

@stevengill stevengill merged commit 94aef8c into slackapi:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support file as payload input
5 participants