Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the readability of example payloads #47

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 24, 2021

Summary

This pull request improves the readability of the payload examples in README. Also, I've renamed the example directory names (again) to better align with README.

Requirements (place an x in each [ ])

@seratch seratch added the documentation Improvements or additions to documentation label Dec 24, 2021
@seratch seratch added this to the 1.17 milestone Dec 24, 2021
@seratch seratch self-assigned this Dec 24, 2021
Copy link

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite improvement to the readability of the payloads. Thanks for taking the time to do this!

@seratch
Copy link
Member Author

seratch commented Jan 4, 2022

Perhaps, merging this PR will cause conflicts with other PRs from the community. I'm fine to hold off this one until we merge the others that came before this PR.

@seratch seratch modified the milestones: 1.17, 1.18 Jan 10, 2022
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@stevengill
Copy link
Member

Probably okay to revisit this PR now

@seratch seratch merged commit 488ca0d into slackapi:main Jan 12, 2022
@seratch seratch deleted the payload-readability branch January 12, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants