Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #51 for env variables in payload json file #71

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

nitintecg
Copy link
Contributor

@nitintecg nitintecg commented Mar 6, 2022

Summary

Describe the goal of this PR. Mention any related Issue numbers.
Fixes #51
Added Code for accessing github context variables in payload json file
Updated Valid TestCase

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2022

CLA assistant check
All committers have signed the CLA.

@seratch seratch added the bug Something isn't working label Mar 6, 2022
@seratch seratch added this to the 1.19 milestone Mar 6, 2022
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is great, thanks so much!

I think this repo needs its settings tweaked as I don't think the integration tests ran on this PR (probably because the repo origin for the PR is not the root repo, for security reasons). Perhaps @stevengill you can enable repo maintainers to allow for PRs to run tests if we approve? I'd like to make sure that the integration test for payload file successfully interpolated the github event data into the message post to ensure this is working properly.

@filmaj filmaj merged commit 2f8da78 into slackapi:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

payload-file-path does not respect env variables in the payload JSON file
5 participants