Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote circuit-retained setup to CircuitCompositionLocals #891

Closed
ZacSweers opened this issue Sep 20, 2023 · 0 comments · Fixed by #931
Closed

Promote circuit-retained setup to CircuitCompositionLocals #891

ZacSweers opened this issue Sep 20, 2023 · 0 comments · Fixed by #931
Labels
discussion Open discussions!

Comments

@ZacSweers
Copy link
Collaborator

With the new back stack state retention support, this more or less feels like a core feature now. Should we promote it to CircuitCompositionLocals and enable it everywhere?
@ZacSweers ZacSweers added the discussion Open discussions! label Sep 20, 2023
@ZacSweers ZacSweers mentioned this issue Oct 5, 2023
Closed
ZacSweers added a commit that referenced this issue Oct 5, 2023
@ZacSweers
Include retained state registry setup in CircuitCompositionLocals
41c8320 
This enables circuit-retained automatically in CircuitCompositionLocals by default, while still allowing overriding it to a no-op impl.

Resolves #891
@ZacSweers ZacSweers mentioned this issue Oct 5, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 5, 2023
@ZacSweers
Include retained state registry setup in CircuitCompositionLocals (#931)
28bc5a4 
This enables circuit-retained automatically in CircuitCompositionLocals
by default, while still allowing overriding it to a no-op impl.

Resolves #891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Open discussions!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include retained state registry setup in CircuitCompositionLocals slackhq/circuit
1 participant
@ZacSweers