Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop sample updates #1000

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Interop sample updates #1000

merged 5 commits into from
Nov 17, 2023

Conversation

stagg
Copy link
Collaborator

@stagg stagg commented Nov 17, 2023

Description

Collection of fixes and changes in the interop sample to get it back up to speed and working.

Changes

Update readme to include the interop project

  • Didn't have the interop sample listed in the samples readme

Fix bug where the screen wouldn't update on selection

  • Changing the presenter or ui sources was not updating as only the initial screen was captured in the movableContentOf

Break the dependency on the counter sample

  • Wasn't really a need to be dependent on the other sample, will make it easier to update the counter sample too

Fix CounterView not calling back on right event sink

  • When the UI was the view and the presenter was switched the event sink wasn't getting updated to the latest

@stagg stagg marked this pull request as ready for review November 17, 2023 19:38
@stagg stagg requested review from ZacSweers and kierse November 17, 2023 19:38
@stagg stagg enabled auto-merge November 17, 2023 19:38
@stagg stagg added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit a40d037 Nov 17, 2023
@stagg stagg deleted the js-samples-interop-updates branch November 17, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants