Merge copies of TestCountPresenter / Ui / Content to new shared module #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/test-presenter
branch
from
3c98b5a to
532ba01
Compare
chrisbanes
force-pushed
the
cb/test-presenter
branch
from
dc251fa to
109718f
Compare
|
This will need manually merging in because of the |
|
I've been talking with Madis about it and he has an idea that could make this work, but with the holidays going on probably haven't been able to pick this up yet. Good idea, I'll see about improving this. Maybe for forks we can make it fall back to using the slower CI emulator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have 3 copies of
TestCountPresenterand friends in the codebase, with more incoming. This PR merges them into a new module:internal-test-utilsfor re-use.