Fix lifetime of Records' ViewModelStores #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
LGTM 🚢
I have a hunch that we can avoid doing all of this by tweaking how the values are stored in NavigableCircuitContent itself, by moving them into the movableContentOf. I'll have a play with that soon, now that we have a nice test case to catch regressions 👌. I don't want to block this on my hunch though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes original issue reported in #1065
The fix in #1086 only made sure the correct ViewModelStore was present, but
ViewModel.onCleared()is still being called upon stack-pop, not once the Presenter/Ui completely left composition.This PR tracks both "stack" lifetime and "ui" lifetime and only clears the ViewModelStore when both have been forgotten. I piggybacked on shared
RememberTypestuff, I hope that's alright.Also fixes
ProvidedValuesLifetimeTestto read the CompositionLocal again, using better special values to hopefully prevent accidental breaking again