Change navigator popUntil to exclusive #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): roy.tk <r***@k***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
vulpeszerda
force-pushed
the
navigator-popuntil-exclusive
branch
from
c67e269 to
aa0d58d
Compare
|
Thanks for the contribution! Before we can merge this, we need @vulpeszerda to sign the Salesforce Inc. Contributor License Agreement. |
ZacSweers
reviewed
Jan 29, 2024
circuit-foundation/src/commonMain/kotlin/com/slack/circuit/foundation/CircuitContent.kt
Outdated
Show resolved
Hide resolved
circuit-test/src/commonMain/kotlin/com/slack/circuit/test/FakeNavigator.kt
Show resolved
Hide resolved
circuit-runtime/src/commonMain/kotlin/com/slack/circuit/runtime/Navigator.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1123, navigator's
popUntilextension worked as inclusively.Because backstack's
popUntilworks exclusively, changed navigator'spopUntilto work as exclusively.For this change, added
peekmethod to navigator.Side-effects that needed to be consider
FakeNavigator.DispatchingOverlayNavigatorto receive current screen as argument and return it when peek called.