Revamp interop sample #1193
Merged
Revamp interop sample #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Carry over current count when switching presenters - Add a smoke test
Why is this key necessary
stagg
reviewed
Mar 25, 2024
samples/interop/src/main/kotlin/com/slack/circuit/sample/interop/SimpleCounterPresenter.kt
Outdated
Show resolved
Hide resolved
stagg
approved these changes
Mar 26, 2024
…op/SimpleCounterPresenter.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stablebecause we're using them as params in some placesOne open question I'm curious for input on - I found that
SimpleCounterPresenter.asCircuitPresenter()needed to key the internal listener creation for some reason, otherwise the subsequent created presenter would reuse this previous instance somehow despite the source presenter being different.Screen_recording_20240324_184846.mp4