Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CM 1.6 #1209

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Update to CM 1.6 #1209

merged 11 commits into from
Feb 27, 2024

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Feb 15, 2024

This updates the project to Compose Multiplatform 1.6.0.

Changes

  • Fixed JS support to use browser() instead of NodeJS.
  • Added toe-holds for WASM support. Can't add it until we get a molecule WASM target.
  • Misc changes along the way for the compose update itself.

Followup work

ClassCastException
    at THROW_CCE (webpack-internal:///../counterApp/kotlin/counterApp.js:9882:11)
    at protoOf.insertTopDown_7i64np_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:287811:96)
    at protoOf.execute_bg9gly_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:104648:17)
    at protoOf.executeAndFlushAllPendingOperations_me43h6_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:105781:44)
    at protoOf.executeAndFlushAllPendingFixups_o2eddv_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:103636:23)
    at protoOf.execute_bg9gly_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:104583:14)
    at protoOf.executeAndFlushAllPendingOperations_me43h6_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:105781:44)
    at protoOf.executeAndFlushAllPendingChanges_o7h1mb_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:101644:30)
    at applyChangesInLocked (webpack-internal:///../counterApp/kotlin/counterApp.js:89414:21)
    at protoOf.applyChanges_ynn7tn_k$ (webpack-internal:///../counterApp/kotlin/counterApp.js:90565:9)
Module["org_jetbrains_skia_paragraph_FontCollection__1nMake"] is not a function

@ZacSweers ZacSweers changed the title Prep for compose 1.6 Update to CM 1.6 Feb 27, 2024
@ZacSweers ZacSweers marked this pull request as ready for review February 27, 2024 20:51
@ZacSweers ZacSweers requested a review from stagg February 27, 2024 20:51
@ZacSweers ZacSweers requested a review from stagg February 27, 2024 21:50
@ZacSweers ZacSweers enabled auto-merge February 27, 2024 21:52
@ZacSweers ZacSweers added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit dcc1475 Feb 27, 2024
6 checks passed
@ZacSweers ZacSweers deleted the z/compose16prep branch February 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants